New review of byte-compile warnings #9

Closed

sergiruiztrepat wants to merge 1 commits from master into master

sergiruiztrepat commented

2021-06-03 19:25:29 +00:00

(Migrated from github.com)

Hi @tecosaur,

Here is my second review of byte-compile warnings.

Hi @tecosaur, Here is my second review of byte-compile warnings.

tecosaur commented

2021-06-04 10:20:35 +00:00

(Migrated from github.com)

Thanks for this! I'd not a fan of the code duplication though. I just stumbled across an example of someone using eval-when-compile to have the macros defining variables be expanded for compilation. I'm going to push a commit trying that and hope that it does the trick 🤞.

Thanks for this! I'd not a fan of the code duplication though. I just stumbled across an example of someone using `eval-when-compile` to have the macros defining variables be expanded for compilation. I'm going to push a commit trying that and hope that it does the trick :crossed_fingers:.

tecosaur commented

2021-06-04 10:32:13 +00:00

(Migrated from github.com)

Hmmm. Unfortunately it seems eval-when-compile tries to execute the expanded macro results too which I think causes the error seen in the CI for the last commit. The idea of this approach (expand macros at compile) does seem nicer to me — if it can be made to work. Might you have any ideas?

Hmmm. Unfortunately it seems `eval-when-compile` tries to execute the expanded macro results too which I think causes the error seen in the CI for the last commit. The idea of this approach (expand macros at compile) does seem nicer to me — if it can be made to work. Might you have any ideas?

sergiruiztrepat commented

2021-06-07 14:14:31 +00:00

(Migrated from github.com)

Hi! At the moment I don't know how to solve it, but I will investigate...

By the way, you told me about a problem with "wrapped lines", but I don't know what do you mean with "wrapped lines". Could you clarify this to me? Thanks!

Hi! At the moment I don't know how to solve it, but I will investigate... By the way, you told me about a problem with "wrapped lines", but I don't know what do you mean with "wrapped lines". Could you clarify this to me? Thanks!

tecosaur commented

2021-06-26 19:25:36 +00:00

(Migrated from github.com)

Please let me know if you have any ideas. Regarding wrapped lines, I'm talking about the effect of visual-line-mode which can cause a long line of text to be split onto another line - and so another line is needed in the screenshot frame but the line count is unchanged. Does that make sense?

Please let me know if you have any ideas. Regarding wrapped lines, I'm talking about the effect of `visual-line-mode` which can cause a long line of text to be split onto another line - and so another line is needed in the screenshot frame but the line count is unchanged. Does that make sense?

sergiruiztrepat commented

2021-06-28 17:28:09 +00:00

(Migrated from github.com)

Hi @tecosaur ,

I have tried several things in order to avoid byte-compile warnings, but they didn't work without code duplication. I am sorry.

About wrapped lines, I understand, I will have a look (depending on time), but you can close this issue if you want.

Thanks!

Hi @tecosaur , I have tried several things in order to avoid byte-compile warnings, but they didn't work without code duplication. I am sorry. About wrapped lines, I understand, I will have a look (depending on time), but you can close this issue if you want. Thanks!

tecosaur commented

2021-06-28 19:08:12 +00:00

(Migrated from github.com)

No need to be sorry, I really appreciate you spending time trying to help out with this.

Glad to hear you're willing to investigate the wrapped lines issue 🙂.

No need to be sorry, I really appreciate you spending time trying to help out with this. Glad to hear you're willing to investigate the wrapped lines issue :slightly_smiling_face:.

tecosaur commented

2022-10-18 02:33:45 +00:00

(Migrated from github.com)

This should be resolved in e7a8941d9f now.

This should be resolved in e7a8941d9ff2274c7f784c4d89c2ed4a70a45b0a now.