Add custom variables for screenshot parameters #4

Closed

KaratasFurkan wants to merge 1 commits from add-custom-variables-for-parameters into master

KaratasFurkan commented

2021-02-05 18:48:45 +00:00

(Migrated from github.com)

Hi, nice package, thank you!

I wanted to change some default parameters but they was hardcoded, so I create custom variables for all of them.

Hi, nice package, thank you! I wanted to change some default parameters but they was hardcoded, so I create custom variables for all of them.

tecosaur commented

2021-02-05 18:50:33 +00:00

(Migrated from github.com)

Hi! Thanks for the PR. These variables are all actually defined in macros 🙂

I'm not a fan of hardcoding either. I don't think I've made this clear in the docs though, I'll address this at some point.

Hi! Thanks for the PR. These variables are all actually defined in macros :slightly_smiling_face: I'm not a fan of hardcoding either. I don't think I've made this clear in the docs though, I'll address this at some point.

KaratasFurkan commented

2021-02-05 19:28:35 +00:00

(Migrated from github.com)

I didn't get the point, do you mean you dynamically created these variables? my changes are pointless?

I realized that my fork is not up to date btw, I will rebase it if you are going to merge this.

I didn't get the point, do you mean you dynamically created these variables? my changes are pointless? I realized that my fork is not up to date btw, I will rebase it if you are going to merge this.

tecosaur commented

2021-02-05 19:44:53 +00:00

(Migrated from github.com)

If you see the macro screenshot--define-infix you'll see it expands to include a defcustom.

If you see the macro `screenshot--define-infix` you'll see it expands to include a `defcustom`.

KaratasFurkan commented

2021-02-05 19:53:18 +00:00

(Migrated from github.com)

Ahh, I see, I feel bad now :(

😄 Lets close this PR.

Ahh, I see, I feel bad now :( 😄 Lets close this PR.

tecosaur commented