tec
/
screenshot.el
1
0
Fork 0
Code Issues 2 Pull Requests Releases Activity

Add options to set screenshot's metadata #17

Merged
lunik1 merged 5 commits from metadata into master 2023-03-28 15:54:43 +00:00
Conversation 6 Commits 5 Files Changed 1 +44 -4
lunik1 commented 2023-03-17 22:53:00 +00:00 (Migrated from github.com)
Copy Link

Adds options for basic screenshot metadata manipulation:

  • Always sets the "software" field to the current version of Emacs and screenshot.el
  • By default, sets the "description" field to the text captured in the screenshot (-md to toggle)
  • By default, sets the "title" to the buffer name in which the screenshot'd text resides (-mt to toggle)
  • Optionally sets "author" to user-full-name (-ma to toggle)
Adds options for basic screenshot metadata manipulation: - Always sets the "software" field to the current version of Emacs and screenshot.el - By default, sets the "description" field to the text captured in the screenshot (`-md` to toggle) - By default, sets the "title" to the buffer name in which the screenshot'd text resides (`-mt` to toggle) - Optionally sets "author" to `user-full-name` (`-ma` to toggle)
tecosaur commented 2023-03-26 17:08:33 +00:00 (Migrated from github.com)
Copy Link

Thanks for this! It looks fairly good 🙂.

One query: have you tried this in combination with screenshot--compress-file ?

Thanks for this! It looks fairly good :slightly_smiling_face:. One query: have you tried this in combination with `screenshot--compress-file` ?
lunik1 commented 2023-03-26 17:25:34 +00:00 (Migrated from github.com)
Copy Link

I had not. It's stripping the metadata for me even without --strip and will always do so on mac.

I had not. It's stripping the metadata for me even without `--strip` and will [always do so on mac.](https://github.com/kornelski/pngquant/issues/280)
lunik1 commented 2023-03-26 17:26:58 +00:00 (Migrated from github.com)
Copy Link

I'n thinking the best way around this is to have metadata setting as a hook that runs after pngquant?

I'n thinking the best way around this is to have metadata setting as a hook that runs after pngquant?
tecosaur commented 2023-03-26 17:35:55 +00:00 (Migrated from github.com)
Copy Link

That sounds like the reasonable way to go

That sounds like the reasonable way to go
lunik1 commented 2023-03-28 13:44:47 +00:00 (Migrated from github.com)
Copy Link

Done, and I've verified the metadata is present both with and without pngquant.

Done, and I've verified the metadata is present both with and without `pngquant`.
tecosaur commented 2023-03-28 14:04:25 +00:00 (Migrated from github.com)
Copy Link

Fantastic! Thanks for this feature :)

Fantastic! Thanks for this feature :)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tec/screenshot.el#17
No description provided.
Delete Branch "metadata"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?