Add Eldoc support #5

Merged

hlissner merged 1 commits from eldoc-support into master

2022-08-07 08:40:52 +00:00

hlissner commented

2022-08-06 16:02:19 +00:00

(Migrated from github.com)

An advice is necessary because org-eldoc-documentation-function (in org-contrib) isn't customizable, but as it's simply a list of OR'ed function calls, a :before-until advice is elegant enough as an alternative.

An advice is necessary because [org-eldoc-documentation-function](https://github.com/emacsmirror/org-contrib/blob/master/lisp/org-eldoc.el#L137) (in org-contrib) isn't customizable, but as it's simply a list of OR'ed function calls, a `:before-until` advice is elegant enough as an alternative.

tecosaur (Migrated from github.com) reviewed 2022-08-06 16:11:51 +00:00

org-glossary.el

tecosaur (Migrated from github.com) commented

2022-08-06 16:11:51 +00:00

Hmm, this is a global change, right? Wouldn't that mean that if I have two buffers with glossary entries, and I turn off org-glossary-mode in one it will affect both?

If so, could it be better to have some advice that's always there, and an advised function that checks for an active org-glossary-mode?

Hmm, this is a global change, right? Wouldn't that mean that if I have two buffers with glossary entries, and I turn off `org-glossary-mode` in one it will affect both? If so, could it be better to have some advice that's always there, and an advised function that checks for an active `org-glossary-mode`?