Address FIXME for org-return #24

Closed

jackmac92 wants to merge 0 commits from master into master

jackmac92 commented

2021-10-28 04:29:19 +00:00

(Migrated from github.com)

I fixed this for myself, and have "borrowed" enough config from you that I thought I should return some

guessing this used to use org-looking-back(deprecated in org 9.0) which had the limit parameter as optional. Since no limit is intended, just pass nil

evidence from docs

Signature
(looking-back REGEXP LIMIT &optional GREEDY)

Documentation
Return non-nil if text before point matches regular expression REGEXP.

Like looking-at except matches before point, and is slower.
LIMIT if non-nil speeds up the search by specifying a minimum
starting position, to avoid checking matches that would start
before LIMIT.

I fixed this for myself, and have "borrowed" enough config from you that I thought I should return some guessing this used to use `org-looking-back`(deprecated in org 9.0) which had the limit parameter as optional. Since no limit is intended, just pass nil evidence from docs ``` text Signature (looking-back REGEXP LIMIT &optional GREEDY) Documentation Return non-nil if text before point matches regular expression REGEXP. Like looking-at except matches before point, and is slower. LIMIT if non-nil speeds up the search by specifying a minimum starting position, to avoid checking matches that would start before LIMIT. ```

tecosaur commented

2021-10-28 04:50:28 +00:00

(Migrated from github.com)

Thanks for this PR 🙂 I'm thinking this is actually nicer without the rx though, so I've done this slightly differently in 00e299c77d.

Thanks for this PR :slightly_smiling_face: I'm thinking this is actually nicer without the `rx` though, so I've done this slightly differently in 00e299c77d0c1ae0907cefb34081e5174b3eacdd.

👍 1