Issues with screenshoting long buffers #7

New Issue

Open

opened 2021-04-11 20:23:21 +00:00 by zackteo · 10 comments

zackteo commented 2021-04-11 20:23:21 +00:00 (Migrated from github.com)

Copy Link

When I screenshot org-mode buffers, it will cut off content after a certain length like so ...

My current workaround is quite silly, I will keep repeating the content until the screenshot expands to fit more content and crop out the rest. Example of screenshot size expanding ...

When I screenshot `org-mode` buffers, it will cut off content after a certain length like so ...  My current workaround is quite silly, I will keep repeating the content until the screenshot expands to fit more content and crop out the rest. Example of screenshot size expanding ... 

👍 1

Jake-Moss commented 2021-08-27 02:05:53 +00:00 (Migrated from github.com)

Copy Link

I have also been running into this for a while but been unable to consistently reproduce until now, it occurs when the Maximum width is too small and lines wrap

Screenshot with Maximum width set to the default 120

Screenshot with Maximum width set to 400

Could this be happening in org buffers when the width of the plain text exceeds the maximum but the displayed doesn't?

I have also been running into this for a while but been unable to consistently reproduce until now, it occurs when the `Maximum width` is too small and lines wrap Screenshot with `Maximum width` set to the default `120`  Screenshot with `Maximum width` set to `400`  Could this be happening in org buffers when the width of the plain text exceeds the maximum but the displayed doesn't?

tecosaur commented 2021-09-09 14:05:43 +00:00 (Migrated from github.com)

Copy Link

Mmm, there's a known issue where line wrapping isn't accounted for — not because I don't care about line wrapping, I just don't know how to determine how many lines are wrapped. If anyone has an idea, I'd love to hear.

Mmm, there's a known issue where line wrapping isn't accounted for — not because I don't care about line wrapping, I just don't know how to determine how many lines are wrapped. If anyone has an idea, I'd love to hear.

tecosaur commented 2022-10-18 02:39:34 +00:00 (Migrated from github.com)

Copy Link

Line wrapping is now accounted for as of dac727e98e. There's a different issue with the posframe maximum height, but that can be another issue if anybody wants to raise it.

Line wrapping is now accounted for as of dac727e98eba67cd553300a704ab4a66e20db733. There's a different issue with the posframe maximum height, but that can be another issue if anybody wants to raise it.

Jake-Moss commented 2022-10-18 09:59:50 +00:00 (Migrated from github.com)

Copy Link

In my testing for #10 I've run into some issues with short screenshots, and just in general

;; Install use-package
(straight-use-package 'use-package)

(setq straight-use-package-by-default t)

• 1line
  

;; Install use-package

• 2 lines
  

;; Install use-package
(straight-use-package 'use-package)

• 3 lines
  

;; Install use-package
(straight-use-package 'use-package)
<< pretend this is empty, github truncates the code block >>

• 4 lines
  

;; Install use-package
(straight-use-package 'use-package)

(setq straight-use-package-by-default t)

• 5 lines
  

;; Install use-package
(straight-use-package 'use-package)

(setq straight-use-package-by-default t)
<< pretend this is empty, github truncates the code block >>

In addition also seems to be truncating the whole buffer (even with -W set to 120 to avoid line wrapping, it still wraps)

;;; init.el --- Description -*- lexical-binding: t; -*-

;; Bootstrap straight
(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 6))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

;; Install use-package
(straight-use-package 'use-package)

(setq straight-use-package-by-default t)

(use-package lsp-mode
  :init
  ;; set prefix for lsp-command-keymap (few alternatives - "C-l", "C-c l")
  (setq lsp-keymap-prefix "C-c l")
  :hook (;; replace XXX-mode with concrete major-mode(e. g. python-mode)
         (c-mode . lsp))
  :config
  (eval-after-load 'lsp-clangd
   '(add-to-list 'lsp-clients-clangd-args "--log=verbose"))
  :commands lsp)

(use-package screenshot
  :straight (:host github :repo "tecosaur/screenshot" :build (:not compile)))

(setq lsp-log-io t)

In my testing for #10 I've run into some issues with short screenshots, and just in general ```lisp ;; Install use-package (straight-use-package 'use-package) (setq straight-use-package-by-default t) ``` - 1line  ```lisp ;; Install use-package ``` - 2 lines  ```lisp ;; Install use-package (straight-use-package 'use-package) ``` - 3 lines  ```lisp ;; Install use-package (straight-use-package 'use-package) << pretend this is empty, github truncates the code block >> ``` - 4 lines  ```lisp ;; Install use-package (straight-use-package 'use-package) (setq straight-use-package-by-default t) ``` - 5 lines  ```lisp ;; Install use-package (straight-use-package 'use-package) (setq straight-use-package-by-default t) << pretend this is empty, github truncates the code block >> ``` In addition also seems to be truncating the whole buffer (even with `-W` set to 120 to avoid line wrapping, it still wraps)  ```lisp ;;; init.el --- Description -*- lexical-binding: t; -*- ;; Bootstrap straight (defvar bootstrap-version) (let ((bootstrap-file (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory)) (bootstrap-version 6)) (unless (file-exists-p bootstrap-file) (with-current-buffer (url-retrieve-synchronously "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el" 'silent 'inhibit-cookies) (goto-char (point-max)) (eval-print-last-sexp))) (load bootstrap-file nil 'nomessage)) ;; Install use-package (straight-use-package 'use-package) (setq straight-use-package-by-default t) (use-package lsp-mode :init ;; set prefix for lsp-command-keymap (few alternatives - "C-l", "C-c l") (setq lsp-keymap-prefix "C-c l") :hook (;; replace XXX-mode with concrete major-mode(e. g. python-mode) (c-mode . lsp)) :config (eval-after-load 'lsp-clangd '(add-to-list 'lsp-clients-clangd-args "--log=verbose")) :commands lsp) (use-package screenshot :straight (:host github :repo "tecosaur/screenshot" :build (:not compile))) (setq lsp-log-io t) ```

tecosaur commented 2022-10-18 10:13:53 +00:00 (Migrated from github.com)

Copy Link

Thanks for those samples. I'll see if that matches what I see.

---

• one line

• two lines

• four lines

• long lines

• long lines with wrapping

---

Seems like the line wrapping was slightly under-counted in the last example, but other than that it seems fine my end 🤔.

With the blank line examples, it's worth notice I've recently made trailing whitespace trimming more aggressive.

Thanks for those samples. I'll see if that matches what I see. ----- - one line  - two lines  - four lines  - long lines  - long lines with wrapping  ----- Seems like the line wrapping was slightly under-counted in the last example, but other than that it seems fine my end :thinking:. With the blank line examples, it's worth notice I've recently made trailing whitespace trimming more aggressive.

Jake-Moss commented 2022-10-18 10:30:08 +00:00 (Migrated from github.com)

Copy Link

Interesting, with no blank lines I'm able to get this results (No. lines 1 -5) using

;; Install use-package
(straight-use-package 'use-package)
;; Another comment
(setq straight-use-package-by-default t)
;; Some more text

All taken using these settings,

Would it be system related?
I'm running Fedora release 36 with Gnome 42.4 and X11.
I've moved over to a vanilla config to hopefully make it reproducible for you.

Interesting, with no blank lines I'm able to get this results (No. lines 1 -5) using ```lisp ;; Install use-package (straight-use-package 'use-package) ;; Another comment (setq straight-use-package-by-default t) ;; Some more text ```      All taken using these settings,  Would it be system related? I'm running Fedora release 36 with Gnome 42.4 and X11. I've moved over to a vanilla config to hopefully make it reproducible for you.

tecosaur commented 2023-01-18 16:45:12 +00:00 (Migrated from github.com)

Copy Link

The cause of this issue was not obvious to me, so it's been slightly forgotten about, but thanks for the vanilla example. If/when I do finally get to this, I expect that to be a big help.

The cause of this issue was not obvious to me, so it's been slightly forgotten about, but thanks for the vanilla example. If/when I do finally get to this, I expect that to be a big help.

👍 1

tecosaur commented 2023-01-20 11:39:50 +00:00 (Migrated from github.com)

Copy Link

@Jake-Moss in the recent batch of development I've done (a whole bunch of improvements 🎉) I may have run into what's causing this. Can you try tweaking the font size and seeing if there's a certain size where the sizing "matches"? It seems the posframe size is calculated based on the size of the active window at the time, not the font size of the buffer about to be shown.

;; Within (defun posframe-show ...)
(font-height (with-current-buffer (window-buffer parent-window)
               (posframe--get-font-height position)))

There's also the issue of the posframe not being able to be generated as larger than the display, which it used to be able to do.

Since these issues are both posframe related, @tumashu might you be able to give any advice here?

@Jake-Moss in the recent batch of development I've done (a whole bunch of improvements :tada:) I may have run into what's causing this. Can you try tweaking the font size and seeing if there's a certain size where the sizing "matches"? It seems the posframe size is calculated based on the size of the active window at the time, not the font size of the buffer about to be shown. ```lisp ;; Within (defun posframe-show ...) (font-height (with-current-buffer (window-buffer parent-window) (posframe--get-font-height position))) ``` There's also the issue of the posframe not being able to be generated as larger than the display, which it used to be able to do. Since these issues are both posframe related, @tumashu might you be able to give any advice here?

❤️ 1

Jake-Moss commented 2023-01-22 12:30:20 +00:00 (Migrated from github.com)

Copy Link

Thanks for your work on this, I've done a bit of testing and you were bang on that there was a good font size that worked.
For me 9 works (sometimes). Unfortunately I've found it also seems to be dependent on the size of my current emacs frame, though that may be related to the "larger than display" issue you mentioned as making the frame larger doesn't effect the output.

I've got a series of screenshots below using this buffer

;;; init.el --- Description -*- lexical-binding: t; -*-

;; Bootstrap straight
(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 6))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

;; Install use-package
(straight-use-package 'use-package)
;; Another comment
(setq straight-use-package-by-default t)
;; Some more text

(use-package lsp-mode
  :init
  ;; set prefix for lsp-command-keymap (few alternatives - "C-l", "C-c l")
  (setq lsp-keymap-prefix "C-c l")
  :hook (;; replace XXX-mode with concrete major-mode(e. g. python-mode)
         (c-mode . lsp))
  :config
  (eval-after-load 'lsp-clangd
   '(add-to-list 'lsp-clients-clangd-args "--log=verbose"))
  :commands lsp)

(use-package screenshot
  :straight (:host github :repo "tecosaur/screenshot" :build (:not compile)))

(setq lsp-log-io t)

(custom-set-variables
 ;; custom-set-variables was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 '(screenshot-font-size 9))
(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so be careful.
 ;; Your init file should contain only one such instance.
 ;; If there is more than one, they won't work right.
 )

• Maximised (title bar still visible), 14 (default font size)
  

• Full screen gnome bar and title bar not visible, 14 (default font size)
  

• Not maximised width, but maximised height, 14
  

• smaller window, 14
  

• maximised, title bar and gnome bar visible, 9
  

• full screen, 9
  

• full height, 9
  

• smaller window, 9
  

Interestingly I couldn't see a difference between maximised and fullscreen.

Thanks for your work on this, I've done a bit of testing and you were bang on that there was a good font size that worked. For me 9 works (sometimes). Unfortunately I've found it also seems to be dependent on the size of my current emacs frame, though that may be related to the "larger than display" issue you mentioned as making the frame larger doesn't effect the output. I've got a series of screenshots below using this buffer ```lisp ;;; init.el --- Description -*- lexical-binding: t; -*- ;; Bootstrap straight (defvar bootstrap-version) (let ((bootstrap-file (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory)) (bootstrap-version 6)) (unless (file-exists-p bootstrap-file) (with-current-buffer (url-retrieve-synchronously "https://raw.githubusercontent.com/radian-software/straight.el/develop/install.el" 'silent 'inhibit-cookies) (goto-char (point-max)) (eval-print-last-sexp))) (load bootstrap-file nil 'nomessage)) ;; Install use-package (straight-use-package 'use-package) ;; Another comment (setq straight-use-package-by-default t) ;; Some more text (use-package lsp-mode :init ;; set prefix for lsp-command-keymap (few alternatives - "C-l", "C-c l") (setq lsp-keymap-prefix "C-c l") :hook (;; replace XXX-mode with concrete major-mode(e. g. python-mode) (c-mode . lsp)) :config (eval-after-load 'lsp-clangd '(add-to-list 'lsp-clients-clangd-args "--log=verbose")) :commands lsp) (use-package screenshot :straight (:host github :repo "tecosaur/screenshot" :build (:not compile))) (setq lsp-log-io t) (custom-set-variables ;; custom-set-variables was added by Custom. ;; If you edit it by hand, you could mess it up, so be careful. ;; Your init file should contain only one such instance. ;; If there is more than one, they won't work right. '(screenshot-font-size 9)) (custom-set-faces ;; custom-set-faces was added by Custom. ;; If you edit it by hand, you could mess it up, so be careful. ;; Your init file should contain only one such instance. ;; If there is more than one, they won't work right. ) ``` - Maximised (title bar still visible), 14 (default font size)  - Full screen gnome bar and title bar not visible, 14 (default font size)  - Not maximised width, but maximised height, 14  - smaller window, 14  - maximised, title bar and gnome bar visible, 9  - full screen, 9  - full height, 9  - smaller window, 9  Interestingly I couldn't see a difference between maximised and fullscreen.

Jake-Moss commented 2023-01-22 13:18:12 +00:00 (Migrated from github.com)

Copy Link

As a side note, changing the font size to 9 has actually fixed this on my wayland + pgtk build. Previously if the font was too large the screenshot would only contain the background.

As a side note, changing the font size to 9 has actually fixed this on my wayland + pgtk build. Previously if the font was too large the screenshot would only contain the background. 

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

v0.2

v0.1

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No Label

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tec/screenshot.el#7

No description provided.