tec/org-mode
tec
/
org-mode
forked from mirrors/org-mode
1
0
Fork 0
Code Pull Requests Releases Activity

org-latex-preview: Indicate errors when using pngs 

* lisp/org-latex-preview.el (org-latex-preview--update-overlay,
org-latex-preview--ensure-overlay): When using dvipng, latex errors
cannot be indicated using an error face, and if a preview is generated
it is indistinguishable from a correct one.  Fall back to a fringe
marker in this situation.
This commit is contained in:
Karthik Chikmagalur 2023-01-07 15:02:41 -08:00 committed by TEC
parent 12f22bd572
commit 9405d8f6b4
Signed by: tec
SSH Key Fingerprint: SHA256:eobz41Mnm0/iYWBvWThftS0ElEs1ftBr6jamutnXc/A
1 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
lisp/org-latex-preview.el
View File

@ -339,14 +339,16 @@ indeed LaTeX fragments/environments.")
(setq ov o)
;; Reset all potentially modified properties.
(overlay-put ov 'face nil)
(overlay-put ov 'hidden-face nil)
(overlay-put ov 'help-echo nil) ;tooltip error display
(overlay-put ov 'before-string nil) ;error fringe marker
(overlay-put ov 'hidden-face nil) ;(re)store svg face
;; Do not set the display property of preview image
;; overlays to nil when ensuring that an overlay exists.
;; This causes flicker during regeneration as the the
;; underlying text is shown and then replaced with the new
;; image.
(overlay-put ov 'preview-image nil)
(overlay-put ov 'preview-state nil)
(overlay-put ov 'preview-image nil) ;(re)store image spec
(overlay-put ov 'preview-state nil) ;is fragment modified?
(overlay-put ov 'view-text nil))))
(unless ov
(setq ov (make-overlay beg end nil 'front-advance))
@ -372,10 +374,11 @@ indeed LaTeX fragments/environments.")
(height (plist-get (cdr path-info) :height))
(depth (plist-get (cdr path-info) :depth))
(errors (plist-get (cdr path-info) :errors))
(image-type (plist-get (cdr path-info) :image-type))
(image-display
(and (car path-info)
(list 'image
:type (plist-get (cdr path-info) :image-type)
:type image-type
:file (car path-info)
:height (and height (cons (* height zoom) 'em))
:ascent (if (and depth height)
@ -401,12 +404,12 @@ indeed LaTeX fragments/environments.")
(when image-display
(overlay-put ov 'display image-display)
(overlay-put ov 'preview-image image-display))
(overlay-put
ov 'face
(cond
((plist-get (cdr path-info) :errors) 'error)
((eq (plist-get (cdr image-display) :type) 'svg)
(or (and (> (overlay-start ov) (point-min))
(cond
((eq image-type 'svg)
(overlay-put
ov 'face
(or (and errors 'error)
(and (> (overlay-start ov) (point-min))
(not (eq (char-before (overlay-start ov)) ?\n))
(let ((face (get-text-property (1- (overlay-start ov)) 'face)))
(cond
@ -414,8 +417,13 @@ indeed LaTeX fragments/environments.")
(cl-set-difference face org-latex-preview--ignored-faces))
((not (memq face org-latex-preview--ignored-faces))
face))))
'default))
(t nil)))))
'default)))
(errors
(overlay-put
ov 'before-string
(propertize "!" 'display
`(left-fringe exclamation-mark
warning)))))))
;; Code for `org-latex-preview-auto-mode':
;;