lexic-mode-process and sdcv is not killed when lexic buffer is closed #24

Open
opened 2021-08-02 11:25:41 +00:00 by minad · 6 comments
minad commented 2021-08-02 11:25:41 +00:00 (Migrated from github.com)

As soon as the user-visible lexic UI is terminated, all associated background processes should be terminated. Is there a reason why one needs a lexic-mode-process buffer btw? Is this the stderr buffer?

As soon as the user-visible lexic UI is terminated, all associated background processes should be terminated. Is there a reason why one needs a lexic-mode-process buffer btw? Is this the stderr buffer?
tecosaur commented 2021-08-05 05:32:31 +00:00 (Migrated from github.com)

Are you sure the process isn't killed? It is for me. How are you closing the buffer? I've implemented the process-killing by adding it to the quit function bound to q, but maybe there's a hook which would be worth using here too.

Are you sure the process isn't killed? It is for me. How are you closing the buffer? I've implemented the process-killing by adding it to the quit function bound to `q`, but maybe there's a hook which would be worth using here too.
minad commented 2021-08-05 08:36:08 +00:00 (Migrated from github.com)

I close it with kill-buffer, maybe also via an Embark action. It would be better to use a hook to detect when the buffer is killed and then terminate the associated process buffer too.

I close it with kill-buffer, maybe also via an Embark action. It would be better to use a hook to detect when the buffer is killed and then terminate the associated process buffer too.
tecosaur commented 2021-08-05 08:37:55 +00:00 (Migrated from github.com)

I'll just add to buffer-kill-hook

I'll just add to `buffer-kill-hook`
minad commented 2022-02-11 07:08:39 +00:00 (Migrated from github.com)

Ping :)

Ping :)
tecosaur commented 2022-02-11 13:48:44 +00:00 (Migrated from github.com)

Ah yes! I completely forgot about this (as you may have guessed 😅). Pushed in 6301a5ad00.

Ah yes! I completely forgot about this (as you may have guessed 😅). Pushed in 6301a5ad00cf8eb74e7a522c84c7ccabbec16241.
minad commented 2022-02-11 22:27:48 +00:00 (Migrated from github.com)

Thanks! It works. One small detail remains - you could also kill the lexic process buffer such that no stale buffers stay around.

Thanks! It works. One small detail remains - you could also kill the lexic process buffer such that no stale buffers stay around.
Sign in to join this conversation.
No description provided.